Skip to content

Fix Policy.launch to be compatible with new ForgeActor.launch API #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Fix Policy.launch to be compatible with new ForgeActor.launch API #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/forge/actors/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,18 @@ def __post_init__(self):
async def launch( # pyright: ignore[reportIncompatibleMethodOverride]
cls: type["Policy"],
*,
process_config: ProcessConfig,
engine_config: EngineConfig | Mapping = EngineConfig(),
sampling_config: SamplingConfig | Mapping = SamplingConfig(),
available_devices: str | None = None,
**kwargs,
) -> "Policy":
# Note - get_proc_mesh will set MASTER_ADDR, MASTER_PORT and CUDA_VISIBLE_DEVICES
# automatically.
process_config: ProcessConfig = ProcessConfig(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no action required.
just curious why this wasn't an issue before? is it because we got rid of process_config in the new config format?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Policy.launch inherited from ForgeActor.launch. This wasn’t an issue before because ForgeActor.launch required process_config. After the PR #195, ForgeActor.launch no longer takes a process_config and constructs a default process_config, but Policy.launch still required it, which is a mismatch.

procs=cls.procs,
hosts=cls.hosts,
with_gpus=cls.with_gpus,
)
worker_procs = await get_proc_mesh(process_config=process_config)

# TODO - issues/144 we will want to ensure colocation with workers
Expand Down
Loading