-
Notifications
You must be signed in to change notification settings - Fork 16
Basic Sandboxed Coder #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Quick updates:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legit
Non-code ask:
- Install instructions (README or just put in the PR description, until it's ready for the core install file)
good call, added to the PR description |
|
||
async def stop_proc_mesh(self, proc_mesh: ProcMesh): | ||
"""Stops a proc mesh.""" | ||
if proc_mesh not in self._proc_host_map: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason a bunch of unit tests were failing due to wrong cleanup. Not sure why I saw this in this PR specifically, but we should have this line anyways. If we want to be really clean I can add this in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits, but looks good!
follow up for #188
Enroot install instructions are here. Commands: