-
Notifications
You must be signed in to change notification settings - Fork 16
[Logging] add time stamp logging + test #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 26 commits
0f63c4e
f18e9a0
f2aa103
0aa9e15
412c453
8ebcc6d
0e6a549
abc6447
4ac667a
c7c34aa
372862d
db27d86
9d2debf
504d7e1
ec86741
8037b7a
292d018
715c74d
83e63b5
7edf942
6a28f9e
f21afb7
60e6382
25caeb0
24a5e96
b726b00
a297090
5535eb6
ece12d7
1af10b1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
|
||
# Force all timing methods in forge.observability.perf_tracker.py to use | ||
# CPU timer if False or GPU timer if True. If unset, defaults to the assigned value to the function. | ||
METRIC_TIMER_USES_CUDA = "METRIC_TIMER_USES_CUDA" | ||
METRIC_TIMER_USES_GPU = "METRIC_TIMER_USES_GPU" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. making it future proof when we support other backends besides cuda There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TPUs here we come There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OH NO There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "METRIC_TIMER_USES_ACCELERATOR"? Is this what torch uses? geez, we refactor it when the time comes |
||
|
||
# Makes forge.observability.metrics.record_metric a no-op | ||
FORGE_DISABLE_METRICS = "FORGE_DISABLE_METRICS" |
Uh oh!
There was an error while loading. Please reload this page.