Skip to content

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Oct 3, 2025

spawn_actors has been removed, so updating to use as_actor API.

Also some updates to the config to make it work.

Test Plan:

python -m apps.sft_v2.main --config apps/sft_v2/llama3_8b.yaml

Output:

[3] [ForgeSFTRecipe-3/8] 2025-10-03 13:14:24 INFO 91 / 1000|Loss: 1.11570405960083
[1] [ForgeSFTRecipe-1/8] 2025-10-03 13:14:24 INFO 92 / 1000|Loss: 0.9416455030441284
[2] [ForgeSFTRecipe-2/8] 2025-10-03 13:14:24 INFO 92 / 1000|Loss: 1.0203598737716675
[3] [ForgeSFTRecipe-3/8] 2025-10-03 13:14:24 INFO 92 / 1000|Loss: 0.8977944254875183
[6] [ForgeSFTRecipe-6/8] 2025-10-03 13:14:24 INFO 92 / 1000|Loss: 1.0252584218978882

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 3, 2025
# this run:
# export HF_HUB_DISABLE_XET=1
# uv run forge download meta-llama/Meta-Llama-3.1-8B-Instruct
# forge download meta-llama/Meta-Llama-3.1-8B-Instruct --output-dir /tmp/Meta-Llama-3.1-8B-Instruct
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have uv installed so this cmd didn't work. is uv necessary?

also, do we still need to do export HF_HUB_DISABLE_XET=1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried 'HF_HUB_DISABLE_XET=1 about ~1 week ago and it broke. I dont think it works well with our devmachines. @joecummings do you know?

Copy link
Contributor

@allenwang28 allenwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@daniellepintz daniellepintz merged commit 16495b6 into main Oct 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants