-
Notifications
You must be signed in to change notification settings - Fork 16
Add Sample-level Logging API #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DNXie
wants to merge
45
commits into
meta-pytorch:main
Choose a base branch
from
DNXie:sample_log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
0f63c4e
add time stamp logging
f18e9a0
delete file
f2aa103
review pass
0aa9e15
nits, tests and linter
412c453
nit + update env flag
8ebcc6d
Merge branch 'main' of https://github.com/meta-pytorch/forge into tim…
0e6a549
delete file + update cfg
abc6447
Merge branch 'main' of https://github.com/meta-pytorch/forge into tim…
4ac667a
update configs
c7c34aa
lint
372862d
reutilize reduce_metrics_states
db27d86
change method name
9d2debf
rename + docstrings
504d7e1
add comment
ec86741
update comments
8037b7a
not initing backends will raise warning instead of breaking
292d018
Merge branch 'main' of https://github.com/meta-pytorch/forge into tim…
715c74d
delete file
83e63b5
config nit
7edf942
sort prints
6a28f9e
rename arg
f21afb7
more arg names
60e6382
more arg names
25caeb0
fix wandb hang
24a5e96
add unit tet for step count
b726b00
change step -> global_step
a297090
Merge branch 'main' of https://github.com/meta-pytorch/forge into tim…
5535eb6
change toy config
ece12d7
remove comment
8f1342c
implement samplers
DNXie 0070123
add accumulator
DNXie a45c075
integrate sampling
DNXie ed8f50e
update init
DNXie 52ea47d
debug; blocked by wandb table upload bug
DNXie 88a543a
a working version
DNXie 62278a6
a working version
DNXie 4478642
fix ci, lint, add few test cases
DNXie e859f3d
resolve comments
DNXie 8ede0cb
simplify sampleAccumulator
DNXie dfba33b
resolve comments2
DNXie 6380f13
fix ci
DNXie 1736df1
more readable
DNXie e0c6f33
add sample log for toy_rl/metrics; support sample log for log_stream
DNXie aab8dc5
use incremental table
DNXie 487c01e
fix import error
DNXie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like this, but i think it can be a bit dangerous. We dont have a dataclass that says the fields that it will hold. You would also need to make sure that the other actors are aware of this change. I am thinking that maybe we should keep
episode.reward: float
and add an extra optional fieldepisode.reward_breakdown: dict[float]
. Wdyt?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly! it comes with two field
reward
andreward_breakdown
. If you look at the line below it: