Skip to content

Metric Logging updates 2/4 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 8, 2025
Merged

Metric Logging updates 2/4 #347

merged 10 commits into from
Oct 8, 2025

Conversation

felipemello1
Copy link
Contributor

@felipemello1 felipemello1 commented Oct 8, 2025 •
edited
Loading

Built on top of 1/4

adds:

  1. Metric class to hold (key, value, reduce type, timestamp), instead of being a dict
  2. BackendRole class as enum for Global/Local
  3. Update step -> global_step
  4. miscellaneous unit tests

Felipe Mello added 2 commits October 8, 2025 08:38
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 8, 2025
@felipemello1 felipemello1 merged commit 7b6743d into meta-pytorch:main Oct 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allenwang28 allenwang28 allenwang28 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felipemello1 @allenwang28