Skip to content

[debugging] also build deps for monarch and vllm #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[debugging] also build deps for monarch and vllm #352

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2660d8c
also upload deps
ebsmothers Oct 8, 2025
8a21310
debug changes
ebsmothers Oct 8, 2025
bbc21cf
Merge branch 'main' into upload-deps
ebsmothers Oct 9, 2025
ef159ac
debug
ebsmothers Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/packaging/pre_build_cpu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ build_vllm() {
export VERBOSE=1
export CMAKE_VERBOSE_MAKEFILE=1
export FORCE_CMAKE=1
pip wheel -v --no-build-isolation --no-deps . -w "$WHL_DIR"
pip wheel -v --no-build-isolation . -w "$WHL_DIR"
}

build_vllm
2 changes: 1 addition & 1 deletion .github/packaging/pre_build_gpu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ build_monarch() {
export RUST_BACKTRACE=1
export CARGO_TERM_VERBOSE=true
export CARGO_TERM_COLOR=always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to do this here or later?

export MONARCH_PACKAGE_NAME="torchmonarch"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I wound up doing this in #355 instead. Let's pursue that one first, then can come back to this after if needed

pip wheel --no-build-isolation --no-deps . -w "$WHL_DIR"
pip wheel --no-build-isolation . -w "$WHL_DIR"
}

append_date() {
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build_vllm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Build pinned vLLM against PyTorch nightly and upload

on:
pull_request:
push:
branches:
- nightly
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build_wheels.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Build nightly wheels and publish to PyTorch Index

on:
pull_request:
push:
branches:
- nightly
Expand Down
Loading