Metric Logging updates 3/N #359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When measuring time with tracer, we have to capture the last time
t2-t1
. I was manually callingt.step("end")
internally, duringt.stop()
, as a way to get this last step between t2-t1. This is used to computetotal_time
, but it should not be logged as an additional step. To drop it, i would just drop last. The logic was brittle, since when doing it cuda, we create threads that run async and dont return results in the order they are sent. This PR addresses it by dropping the"sort + drop last"
logic. Instead, we create an unique name for this step, pop it from the list, and return it as a number apart.