Skip to content

[easy] FORGE_DISABLE_METRICS also disables Tracer #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
Merged

[easy] FORGE_DISABLE_METRICS also disables Tracer #366

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ef5675
<Replace this line with a title. Use 1 line only, 67 chars or less>
Oct 9, 2025
8c884b6
fix logic
Oct 9, 2025
2925852
add lower
Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/forge/observability/perf_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@

import torch

from forge.env_constants import DISABLE_PERF_METRICS, METRIC_TIMER_USES_GPU
from forge.env_constants import (
DISABLE_PERF_METRICS,
FORGE_DISABLE_METRICS,
METRIC_TIMER_USES_GPU,
)
from forge.observability.metrics import record_metric, Reduce

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -108,7 +112,10 @@ def __init__(
self.prefix = prefix
self.track_memory = track_memory
self.time_with_gpu = timer == "gpu"
self._disable = os.getenv(DISABLE_PERF_METRICS, "false") == "true"
self._disable = (
os.getenv(DISABLE_PERF_METRICS, "false").lower() == "true"
or os.getenv(FORGE_DISABLE_METRICS, "false").lower() == "true"
)
self._active = False

# Timing state
Expand Down
Loading