Skip to content

Conversation

JenniferWang
Copy link
Contributor

image

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 14, 2025
@JenniferWang JenniferWang marked this pull request as ready for review October 14, 2025 20:53
@joecummings
Copy link
Member

Lol we sure about this?

@JenniferWang
Copy link
Contributor Author

Lol we sure about this?

What's the other common way for people to track the test passing status on Github? I am indifferent so long as there's a way for us to track

@joecummings
Copy link
Member

Lol we sure about this?

What's the other common way for people to track the test passing status on Github? I am indifferent so long as there's a way for us to track

This is definitely the right way to do things. I'm just concerned that lots of stuff will be broken to start and we'll have a constantly red badge :/

@casteryh
Copy link
Contributor

Lol we sure about this?

What's the other common way for people to track the test passing status on Github? I am indifferent so long as there's a way for us to track

This is definitely the right way to do things. I'm just concerned that lots of stuff will be broken to start and we'll have a constantly red badge :/

If that's the case, maybe we should have constant red badge then.

@JenniferWang JenniferWang merged commit 65e75c3 into main Oct 15, 2025
9 checks passed
allenwang28 pushed a commit to allenwang28/forge that referenced this pull request Oct 15, 2025
@casteryh casteryh deleted the add-CI-badges branch October 16, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants