Skip to content

Conversation

Jack-Khuu
Copy link
Contributor

2 Minor Tutorial Edits:

  • Changed PolicyActor to Policy Actor: PolicyActor isn't a true class; Actor is the subclass of Policy
    i.e. Policy(ForgeActor)
  • Updated import statement to alias Generator to Policy
    from forge.actors.generator import Generator as Policy
    • Usage of "Policy" as variables/RL concept is intentionally unchanged

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 16, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.74%. Comparing base (633b219) to head (47d01c2).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   64.69%   64.74%   +0.05%     
==========================================
  Files          79       79              
  Lines        7775     7772       -3     
==========================================
+ Hits         5030     5032       +2     
+ Misses       2745     2740       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

```python

from forge.actors.policy import Policy
from forge.actors.generator import Generator as Policy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Why not just keep as Generator everywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because our docs/tutorials are written with Policy as the logical component and I wanted to avoid a mass change.

If we think it's worth it, we can do another pass pushing the abstraction deeper

@Jack-Khuu Jack-Khuu merged commit ab840ed into main Oct 16, 2025
9 checks passed
@Jack-Khuu Jack-Khuu deleted the policydoc branch October 17, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants