Skip to content

Add FORGE_DISABLE_METRICS check when init_backend #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
Merged

Add FORGE_DISABLE_METRICS check when init_backend #440

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce52c76
check FORGE_DISABLE_METRICS flag when init
DNXie Oct 16, 2025
ea5529d
update
DNXie Oct 16, 2025
ddacf0b
cleanup
DNXie Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/forge/observability/metric_actors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ async def get_or_create_metric_logger(
"""
# Get or create the singleton global logger
global _global_logger

if _global_logger is None:
_global_logger = await get_or_spawn_controller(
"global_logger", GlobalLoggingActor
Expand Down Expand Up @@ -203,6 +204,9 @@ async def init_backends(self, config: dict[str, Any]) -> None:
"""
self.config = config

if FORGE_DISABLE_METRICS.get_value():
return

for backend_name, backend_config in config.items():
backend = get_logger_backend_class(backend_name)(backend_config)
await backend.init(role=BackendRole.GLOBAL)
Expand Down
Loading