Add warning for existing build/ directory in env setup #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
The env_setup.sh script now checks for an existing build/ directory before installing the forge package. If found, it warns the user that the directory may contain artifacts from a previous pip installation that could interfere with the current installation. The user is prompted to continue or cancel, with instructions on how to manually remove the build/ directory if they encounter issues.
casteryh
force-pushed
the
warn-existing-build-dir
branch
from
f1596eb to
ed14fae
Compare
allenwang28
reviewed
Oct 16, 2025
| log_warn "Detected existing build/ directory at: $(pwd)/build" | ||
| log_warn "This directory may contain artifacts from a previous pip installation" | ||
| log_warn "that could interfere with the current installation." | ||
| log_warn "If you encounter issues, manually remove it with: rm -rf build" |
There was a problem hiding this comment.
what is the risk of always deleting it all? lol
JenniferWang
approved these changes
Oct 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 64.69% 64.63% -0.06%
==========================================
Files 79 79
Lines 7775 7788 +13
==========================================
+ Hits 5030 5034 +4
- Misses 2745 2754 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
build/directory before installing the forge package in.meta/mast/env_setup.shTest plan