Skip to content

Conversation

Jack-Khuu
Copy link
Contributor

As titled. Specifically removed:

  • interfaces.py: Environment, Policy
  • types.py: ForgeEnvInfo, Action, Trajectory, State

Also test_replay_buffer was updated to use a locally defined TestEpisode instead of a Trajectory since the test was the only caller of Trajectory (and was using it more as a proxy for Episode due to the definition not being centralized)


python -m pytest tests/unit_tests/test_replay_buffer.py::TestReplayBuffer

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2025
@Jack-Khuu
Copy link
Contributor Author

Failing on deleted env tests: Will be rebased onto and landed after #443

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.48%. Comparing base (248126a) to head (3b89a92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   63.57%   63.48%   -0.09%     
==========================================
  Files          77       77              
  Lines        7569     7526      -43     
==========================================
- Hits         4812     4778      -34     
+ Misses       2757     2748       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jack-Khuu Jack-Khuu merged commit bbb9735 into main Oct 17, 2025
9 checks passed
@Jack-Khuu Jack-Khuu deleted the remove-interfaces branch October 17, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants