Skip to content

Conversation

@wukaixingxp
Copy link
Contributor

@wukaixingxp wukaixingxp commented Oct 20, 2025

Summary:

Current wandb config is hard-coded to only take project,and group, as shown in this line and the other configs like entity is totally ignored. This PR fixed this issue and allow other arguments to be passed into wandb config.

Test Plan:

with entity:

Run this following training python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yaml with configs like:

# Observability configuration
metric_logging:
  wandb:
    entity: torchforge
    project: "kaiwu-coding-grpo"
    reduce_across_ranks: True
  console:
    reduce_across_ranks: True

saw the log:

wandb: 
wandb: 🚀 View run smart-bush-1 at: https://meta.wandb.io/torchforge/kaiwu-coding-grpo/runs/8bf85azv
wandb: Find logs at: wandb/run-20251020_101829-8bf85azv/logs

without entity

removing the entity from config:

metric_logging:
  wandb:
    project: "kaiwu-coding-grpo"
    reduce_across_ranks: True
  console:
    reduce_across_ranks: True

training is running and now saw :

wandb: Tracking run with wandb version 0.22.2
wandb: Run data is saved locally in /home/kaiwu/work/kaiwu/forge/wandb/run-20251020_105711-hcazo06j
wandb: Run `wandb offline` to turn off syncing.
wandb: Syncing run dark-energy-11
wandb: ⭐️ View project at https://meta.wandb.io/kaiwu/kaiwu-coding-grpo
wandb: 🚀 View run at https://meta.wandb.io/kaiwu/kaiwu-coding-grpo/runs/hcazo06j

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 20, 2025
@casteryh
Copy link
Contributor

casteryh commented Oct 20, 2025

Can you confirm this doesn't break anything if entity is left to be None? Otherwise LGTM

@casteryh casteryh self-requested a review October 20, 2025 17:51
@wukaixingxp
Copy link
Contributor Author

Can you confirm this doesn't break anything if entity is left to be None? Otherwise LGTM

@casteryh Sure.. I tested without entity and added that log back to test plan

@felipemello1
Copy link
Contributor

@wukaixingxp, thanks for opening the PR! Let me address it in another PR. This works, but the changes need to be a bit more holistic to work with every backend. Let me open it and get your feedback. Does that work for you?

@wukaixingxp
Copy link
Contributor Author

@wukaixingxp, thanks for opening the PR! Let me address it in another PR. This works, but the changes need to be a bit more holistic to work with every backend. Let me open it and get your feedback. Does that work for you?

Sure. I will close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants