Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Current wandb config is hard-coded to only take
project,andgroup, as shown in this line and the other configs likeentityis totally ignored. This PR fixed this issue and allow other arguments to be passed into wandb config.Test Plan:
with
entity:Run this following training
python -m apps.grpo.main --config apps/grpo/qwen3_1_7b.yamlwith configs like:saw the log:
without
entityremoving the entity from config:
training is running and now saw :