Skip to content

prepare for monarch behavior change #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

prepare for monarch behavior change #480

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4a9399
create task to ensure parallel execution
casteryh Oct 21, 2025
838a4a9
remove task group since it doesn't work with python 3.10
casteryh Oct 21, 2025
6d5df6a
set flag instead
casteryh Oct 21, 2025
9c00682
remove empty lines
casteryh Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/forge/actors/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,11 +270,16 @@ def split_keys(keys):
return [keys[i::n_fetchers] for i in range(n_fetchers)]

futures = []
for i, names in enumerate(split_keys(hf_param_names)):
fut = self.weight_fetchers.slice(procs=i).fetch.call_one(
version=version, param_names=names
)
futures.append(fut)
async with asyncio.TaskGroup() as tg:
for i, names in enumerate(split_keys(hf_param_names)):

async def fetch_coro():
return self.weight_fetchers.slice(procs=i).fetch.call_one(
version=version, param_names=names
)

fut = tg.create_task(fetch_coro())
futures.append(fut)

sub_state_dicts = [await fut for fut in futures]

Expand Down
Loading