Metric Logging - Enable kwargs so user can add extra args #482
+96
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we would pass a whole dictionary as input to a logger backend and pop a selected few args
This means that if users want to pass extra args, e.g. run name or tags, they couldnt.
Now we use
**kwargsand pass it directly to the wandb run:Tested it with multiple args. We can even pass a custom name. e.g.
logging_mode: global_reduce

logging_mode: per_rank_reduce
