Skip to content

Don't stop throwaway procs #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Don't stop throwaway procs #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/forge/controller/provisioner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ async def get_remote_info(host_mesh: HostMesh) -> tuple[str, str]:
# Fetcher should be a singleton at this point - call_one() will fail otherwise

host, port = await fetcher.get_info.call_one()
await throwaway_procs.stop()

# Stopping this proc is the right thing to do, but Monarch does not yet handle manual stops well.
# await throwaway_procs.stop()
return host, port


Expand Down
Loading