Skip to content

Conversation

@jeis4wpi
Copy link
Contributor

propose fix some typos

@meta-cla
Copy link

meta-cla bot commented Oct 24, 2025

Hi @jeis4wpi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla
Copy link

meta-cla bot commented Oct 24, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 24, 2025
.gitignore Outdated
*.log
*.swp
.DS_Store
*~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

@casteryh
Copy link
Contributor

Thanks! Just had one question.

@jeis4wpi
Copy link
Contributor Author

jeis4wpi commented Oct 24, 2025 via email

@casteryh
Copy link
Contributor

Suggest blocking emacs backup files also * John
________________________________ From: casteryh @.> Sent: Friday, October 24, 2025 12:22:06 PM To: meta-pytorch/torchforge @.> Cc: John Eismeier @.>; Mention @.> Subject: Re: [meta-pytorch/torchforge] propose fix some typos (PR #501) @casteryh commented on this pull request.
________________________________ In .gitignore<#501 (comment)>:
@@ -166,6 +166,7 @@ docs/src
.log .swp .DS_Store +~ ⬇️ Suggested change -~ — Reply to this email directly, view it on GitHub<#501 (review)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKFTXFVGLHGEDUU5YDD4JNT3ZJG25AVCNFSM6AAAAACKDT2PUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNZXG42DQMBRHE. You are receiving this because you were mentioned.Message ID: @.***>

Thanks for the explanation!
I think it makes more sense for this to be in your personal .gitignore_global file since different people have different setups and the glob pattern *~ seems general enough to cause confusion for people not using emacs.

@casteryh casteryh merged commit 91fcfaf into meta-pytorch:main Oct 24, 2025
6 checks passed
@jeis4wpi
Copy link
Contributor Author

jeis4wpi commented Oct 24, 2025 via email

photomz pushed a commit to photomz/forge that referenced this pull request Oct 25, 2025
Signed-off-by: John E <[email protected]>
Co-authored-by: casteryh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants