-
Notifications
You must be signed in to change notification settings - Fork 49
propose fix some typos #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: John E <[email protected]>
|
Hi @jeis4wpi! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
.gitignore
Outdated
| *.log | ||
| *.swp | ||
| .DS_Store | ||
| *~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for?
|
Thanks! Just had one question. |
|
Suggest blocking emacs backup files also
*
John
________________________________
From: casteryh ***@***.***>
Sent: Friday, October 24, 2025 12:22:06 PM
To: meta-pytorch/torchforge ***@***.***>
Cc: John Eismeier ***@***.***>; Mention ***@***.***>
Subject: Re: [meta-pytorch/torchforge] propose fix some typos (PR #501)
@casteryh commented on this pull request.
________________________________
In .gitignore<#501 (comment)>:
@@ -166,6 +166,7 @@ docs/src
*.log
*.swp
.DS_Store
+*~
⬇️ Suggested change
-*~
—
Reply to this email directly, view it on GitHub<#501 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKFTXFVGLHGEDUU5YDD4JNT3ZJG25AVCNFSM6AAAAACKDT2PUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNZXG42DQMBRHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks for the explanation! |
|
Okay, I saw backup vim files and thought another text editor made sense.
*
John
…________________________________
From: casteryh ***@***.***>
Sent: Friday, October 24, 2025 12:50:25 PM
To: meta-pytorch/torchforge ***@***.***>
Cc: John Eismeier ***@***.***>; Mention ***@***.***>
Subject: Re: [meta-pytorch/torchforge] propose fix some typos (PR #501)
Merged #501<#501> into main.
—
Reply to this email directly, view it on GitHub<#501 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKFTXFTV63FSF7LPEFTPSAL3ZJKFDAVCNFSM6AAAAACKDT2PUSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGQ4DQOBVGU4TENY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Signed-off-by: John E <[email protected]> Co-authored-by: casteryh <[email protected]>
propose fix some typos