[RFC] - Config is code #512
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
This PR showcases different styles for our config system, exploring the "config is code" philosophy. Implements 5 approaches: 1. OmegaConf/Hydra (YAML-based) 2. Fiddle (Google's config library) 3. Factory + dataclasses 4. Plain Python with functools.partial 5. Plain Python with dictionaries Each approach demonstrates handling of: - Lazy instantiation - Nested component instantiation - Partial application for runtime args - Config composition and overrides
felipemello1
force-pushed
the
config_is_code
branch
from
ec6a892 to
55c308d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to showcase the different styles we could use for our config system. A push here is if we can leave the .yaml and use .py instead, under the reasoning that "config is code".
Python can enable a) better type safety, b) import directly instead of using strings, and c) more flexibility for the user to define custom code within the config.
On the other hand, yaml can be easier to read and hydra provides some nice freebies.
Must have:
Nice to have:
Proposed options:
TODO: toml
I would like to hear what others think about the options, if we should stick with yaml and fully explore hydra/omegaconf or change to .py system.