Skip to content

Conversation

@HosseinKaviani-H
Copy link
Contributor

Monarch actors require all endpoints to be either sync or async, not mixed. This change makes has_fetcher and get_fetcher_count async to match other endpoints in GlobalLoggingActor, preventing actor deadlock errors.

Monarch actors require all endpoints to be either sync or async, not mixed.
This change makes has_fetcher and get_fetcher_count async to match other
endpoints in GlobalLoggingActor, preventing actor deadlock errors.
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 31, 2025
@felipemello1
Copy link
Contributor

thanks for the PR! could you please check all the places where those are being called and see if we need to add an await?

@HosseinKaviani-H
Copy link
Contributor Author

thanks for the PR! could you please check all the places where those are being called and see if we need to add an await?
Both methods are safe:

has_fetcher is a single call which already uses await: Location: src/forge/observability/metric_actors.py:106.
get_fetcher_count: not used anywhere in the codebase

Copy link
Contributor

@felipemello1 felipemello1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR. Will merge when tests pass

@felipemello1 felipemello1 merged commit b3c8bc6 into meta-pytorch:main Oct 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants