Skip to content

Conversation

allenwang28
Copy link
Contributor

@allenwang28 allenwang28 commented Aug 14, 2025

This PR

  • Cleans up unused tests
  • Fixes the existing tests
  • Adds in an initial CI yaml file (forked from Monarch)
  • Since we added services, I am also removing stack because it keeps breaking with Monarch updates and is essentially obsolete...

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 14, 2025
@allenwang28 allenwang28 changed the title [WIP] Initial CI suport Adds initial CI suport Aug 14, 2025
Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a hero for adding this. Just make sure the CI actually runs

Copy link
Member

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll come back to this and fix when higher priority. Right now I don't consider this a P0.

Blocking b/c there should be a signal in CI before landing, therefore something isn't working.

@allenwang28
Copy link
Contributor Author

I'll come back to this and fix when higher priority. Right now I don't consider this a P0.

Blocking b/c there should be a signal in CI before landing, therefore something isn't working.

This PR now runs all of the tests on CPU! please take another look

Copy link
Member

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cleanup - thanks for this!

args: ['--branch=main']
- id: check-added-large-files
args: ['--maxkb=1000']
# - id: check-added-large-files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove if not needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing this because pip install torchnightly doesn't work... I know the right thing is to fix that, but I hope you understand that will be difficult for a bit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - can you just refer to it in the pyproject.toml as e.g. "mylib @ file:///${PROJECT_ROOT}/dist/mylib-0.1.0-py3-none-any.whl"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is mostly because the pyproject.toml uses it, similar to torchtitan does it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But does it need it to run? IIUC, it should not and I'd prefer not to add until necessary.

@allenwang28 allenwang28 merged commit ec327fd into meta-pytorch:main Aug 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants