Skip to content

Fix SLURM Launcher: Add Hyperactor Import and Use TcpWithHostname Transport #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HosseinKaviani-H merged 2 commits into from
Nov 18, 2025
Merged

Fix SLURM Launcher: Add Hyperactor Import and Use TcpWithHostname Transport #582

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4be7e6
Fix launcher issues
Nov 17, 2025
37ab4c6
Update src/forge/controller/launcher.py
allenwang28 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/forge/controller/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from monarch.actor import Actor, endpoint, ProcMesh
from monarch.tools import commands
from monarch.tools.commands import create, info
from monarch.tools.components import hyperactor
from monarch.tools.config import Config, Workspace

_MAST_AVAILABLE = False
Expand Down Expand Up @@ -126,7 +127,8 @@ async def initialize(self) -> None:
# HostMesh currently requires explicit configuration
# of the underlying transport from client to mesh.
# This can be removed in the future once this has been removed.
configure(default_transport=ChannelTransport.Tcp)
# Changed TCP this to TcpWithHostname for the slurm launcher
configure(default_transport=ChannelTransport.TcpWithHostname)

async def get_allocator(self, name: str, num_hosts: int) -> tuple[Any, Any, str]:
appdef = hyperactor.host_mesh(
Expand Down
Loading