-
Notifications
You must be signed in to change notification settings - Fork 69
Add new feature request template #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Describe the problem you're trying to solve or the use case for this feature. | ||
| What is the motivation behind this request? Why would this feature be valuable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine to keep as is, but i think it could be a one liner
| required: true | ||
| - type: textarea | ||
| attributes: | ||
| label: 💡 What does this look like in pseudo-code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if i like this. The intention is good, but maybe too much overhead? e.g. someone requesting multiturn or LoRA. Do they need to come up with a design? Perhaps we could reword to something like "Share any examples or pseudo-code if you have it"
| required: false | ||
| - type: textarea | ||
| attributes: | ||
| label: ✅ Acceptance Criteria |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, intention is good, but it feels like a bit too much overhead. How would an user fill this with "request for LoRA" or "request for multiturn"?
felipemello1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still a bit skeptical about the complexity of the template, but lets merge it. Please try create a couple of dummy issues as if you were an user. If it feels like a nice experience, we keep it as is, otherwise we see what we can remove/simplify
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 84.10% 83.23% -0.88%
==========================================
Files 29 31 +2
Lines 3687 3954 +267
==========================================
+ Hits 3101 3291 +190
- Misses 586 663 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.