Skip to content

Update forge references to torchforge in MAST setup #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Update forge references to torchforge in MAST setup #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .meta/mast/client_bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ if [ -z "$WORKSPACE_DIR" ] || [ ! -d "$WORKSPACE_DIR" ]; then
WORKSPACE_DIR="$CONDA_PREFIX"
fi

cd "$WORKSPACE_DIR/forge"
cd "$WORKSPACE_DIR/torchforge"

# Execute the client training script with all passed arguments
exec python -X faulthandler .meta/mast/main.py "$@"
4 changes: 2 additions & 2 deletions src/forge/controller/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def __init__(
self.timeout_sec = 1 * 60 * 60 # Kill the job if idle for 1 hour
self.user = getpass.getuser()
self.work_dir = f"/home/{self.user}"
self.edittable_workspaces = ["forge"]
self.edittable_workspaces = ["torchforge"]
self.remote_work_dir = "/packages/monarch_default_workspace/workspace/"
self.editable_workspace_paths = [
f"{self.work_dir}/{workspace}" for workspace in self.edittable_workspaces
Expand Down Expand Up @@ -367,7 +367,7 @@ def _create_client_role(self, appdef: specs.AppDef) -> specs.Role:
# Override with client-specific configuration
client_role.name = "client"
# Use the bootstrap script as entrypoint
client_role.entrypoint = "workspace/forge/.meta/mast/client_bootstrap.sh"
client_role.entrypoint = "workspace/torchforge/.meta/mast/client_bootstrap.sh"

# Build args for the client role (passed to the bootstrap script)
# These args will be passed to client_bootstrap.sh which forwards them to main.py
Expand Down
Loading