Add StatefulSampler interface and implement RandomStatefulSampler #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 27, 2025
Closed
meta-cla
bot
added
the
CLA Signed
casteryh
force-pushed
the
pr79
branch
2 times, most recently
from
02f4775 to
0803784
Compare
Summary: Added `BufferView` and `RawBuffer` interface. A sampler will operate on a BufferView and return the sampled keys. A ReplayBuffer will own a RawBuffer and operate on that. Test Plan: n/a
Summary: Implement SimpleRawBuffer, a RawBuffer backed by a python dict. Test Plan: unit tests
Summary: This diff adds a new interface called `StatefulSampler` and implements a new class called `RandomStatefulSampler`. The `RandomStatefulSampler` class is a stateful sampler that uses Python's `random.sample` function for deterministic sampling. Test Plan: unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a new interface called
StatefulSamplerand implements a new class calledRandomStatefulSampler.The
RandomStatefulSamplerclass is a stateful sampler that uses Python'srandom.samplefunction for deterministic sampling.Test Plan:
unit tests
Stack created with Sapling. Best reviewed with ReviewStack.