Skip to content

Conversation

DNXie
Copy link
Member

@DNXie DNXie commented Aug 28, 2025

Update the metric logger to take integer logging freq. When integer is passed, all metrics will be logged at this frequency.

Test:
Tested with the config:

metrics:
  logger: wandb
  project: llama3_sft
  freq: 10

The loss was logged every ten steps
image

@DNXie DNXie requested a review from ebsmothers August 28, 2025 01:12
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 28, 2025
Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@DNXie DNXie merged commit 28aa995 into meta-pytorch:main Aug 28, 2025
4 checks passed
@DNXie DNXie deleted the meric_logger_freq branch September 10, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants