-
Notifications
You must be signed in to change notification settings - Fork 16
Integrate metric logger into grpo training loop #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
da21e1d
Add reward interface, math reward, unit tests
DNXie 5c72908
Merge branch 'meta-pytorch:main' into main
DNXie b4d7a61
Merge branch 'meta-pytorch:main' into main
DNXie 02d77c6
Merge branch 'meta-pytorch:main' into main
DNXie fd1d38b
Merge branch 'meta-pytorch:main' into main
DNXie bec7c77
integrate metric logger
DNXie d3e8173
don't know why this was added..
DNXie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to make sure that the input is a dictionary, like here: https://github.com/pytorch/torchtune/blob/67ab86b94de9e7ac7dd9850113ebe69e2bbd307c/recipes/full_finetune_distributed.py#L909
I think that we will have an abundance of metrics coming from dataset and reliability metrics. This is how i envisioned it being used: https://fb.workplace.com/groups/1189731669410969/permalink/1279384097112392/
I understand that its a a simple PR just to get logging started. Just sharing where I think we should land after a few iterations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah great callout, but lets land this one for now and iterate to that point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felipemello1 Thanks for the suggestions! This is a simple PR to simply integrate the logger. In my next PR, I will add logging for various metrics using log_dict.
@joecummings Thanks for approval. I will go ahead and land this one for now.