Skip to content

Integrate reward functions into grpo main #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 28, 2025
Merged

Integrate reward functions into grpo main #87

merged 9 commits into from
Aug 28, 2025

Conversation

DNXie
Copy link
Member

@DNXie DNXie commented Aug 28, 2025

Integrate reward functions into grpo main

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 28, 2025
joecummings
joecummings approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can and should delete the impl I put in grpo.main before merging

@DNXie
Copy link
Member Author

DNXie commented Aug 28, 2025

You can and should delete the impl I put in grpo.main before merging

@joecummings Removed. Good catch! I will land this one.

@DNXie DNXie merged commit 8770c03 into meta-pytorch:main Aug 28, 2025
4 checks passed
@DNXie DNXie deleted the integrate_reward branch September 10, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joecummings joecummings joecummings approved these changes

@pbontrager pbontrager Awaiting requested review from pbontrager

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DNXie @joecummings