Group Rollout Trainer Changes #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
joecummings
approved these changes
Sep 2, 2025
Member
joecummings
left a comment
joecummings
left a comment
There was a problem hiding this comment.
Couple questions, but generally looks good
Jack-Khuu
reviewed
Sep 2, 2025
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
pbontrager
changed the title
photomz
pushed a commit
to photomz/forge
that referenced
this pull request
Oct 25, 2025
* first changes * core updates * batch update * fix typo * missing import * debug merge * more fixes * Remove dtype warnings * Stub * It runs * Add in ref * Pass linting? * Remove extraneous 'calculations' * Stub out push weights * Remove tokenizer, add back in formatting * Cleanup * Updated default group * update CI * added tyro * reverted build changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates each part of the calculations to use reference versions. It also updates the data structures to handle batched processing and be group agnostic.