Skip to content

fbcode/torchft/torchft #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
facebook-github-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fbcode/torchft/torchft #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions torchft/diloco_regression_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def train_loop(self) -> Dict[str, Any]:
manager_steps.add(manager_curr_step)

# For each parameter, set a deterministic gradient
for _, layer in enumerate(self.model.layers):
for layer in self.model.layers:
if isinstance(layer, MockLinear):
# Set fixed gradients
layer.weight.grad = (
Expand Down Expand Up @@ -356,7 +356,7 @@ def test_diloco_mocked_updates(
)
futures.append(executor.submit(runner.run_replica))

for fut in as_completed(futures):
for _fut in as_completed(futures):
continue

results = []
Expand Down Expand Up @@ -440,7 +440,7 @@ def test_diloco_mocked_failure_recovery(
futures.append(executor.submit(runner.run_replica))

# Wait for all futures to complete
for fut in as_completed(futures):
for _fut in as_completed(futures):
continue

results = []
Expand Down Expand Up @@ -503,9 +503,7 @@ def _check_against_fixture(
return False

# Compare fixture data with current results
for replica_idx, (fixture_history, current_history) in enumerate(
zip(fixture_data, results)
):
for fixture_history, current_history in zip(fixture_data, results):
fixture_history = fixture_history[0]["history"]
current_history = current_history[0]["history"]
for step, fixture_params in fixture_history.items():
Expand Down
Loading