Skip to content

[torchft] Only reset_fr_recording_nccl if that attribute is available #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimothySeah wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[torchft] Only reset_fr_recording_nccl if that attribute is available #314

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4959b91
[torchft] Only reset_fr_recording_nccl if that attribute is available
TimothySeah Feb 21, 2026
bd8d50c
lint fixes
TimothySeah Feb 26, 2026
38f1ea1
rerun ci
TimothySeah Feb 28, 2026
0ebf9cd
add warning
TimothySeah Mar 4, 2026
3786568
empty commit to retrigger ci
TimothySeah Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion torchft/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,9 @@ def _async_quorum(
f"resetting fr recording for quorum id {self._quorum_id}"
)
self._update_fr_path()
torch._C._distributed_c10d._reset_fr_recording_nccl() # pyre-ignore
# Only reset FR recording if available (requires NCCL Flight Recorder support)
if hasattr(torch._C._distributed_c10d, "_reset_fr_recording_nccl"):
torch._C._distributed_c10d._reset_fr_recording_nccl() # pyre-ignore
except Exception as e:
self._logger.exception(f"got exception in pg configure: {e}")
self.report_error(e)
Expand Down
Loading