Skip to content

Cleanup deprecated usages of package monarch.utils in torchft #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dulinriley wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleanup deprecated usages of package monarch.utils in torchft #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/monarch/train_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import torch
from monarch.actor import Actor, current_rank, endpoint, HostMesh, ProcMesh, this_host
from monarch.job import SlurmJob
from monarch.utils import setup_env_for_distributed
from monarch.spmd import setup_torch_elastic_env_async
from torchtitan.config import ConfigManager, JobConfig
from torchtitan.tools.logging import init_logger, logger
from torchtitan.train import Trainer
Expand Down Expand Up @@ -157,7 +157,7 @@ async def start_replica(self) -> None:

async with trainers_proc_mesh:
await trainers_proc_mesh.logging_option(stream_to_client=True)
await setup_env_for_distributed(trainers_proc_mesh)
await setup_torch_elastic_env_async(trainers_proc_mesh)

training_actors = trainers_proc_mesh.spawn(
"training_actors",
Expand Down
Loading