Skip to content

lighthouse/quorum: make it clear that quorum logs are for next quorum#79

Merged
d4l3k merged 1 commit intomainfrom
d4l3k/quorum_logs
Jan 23, 2025
Merged

lighthouse/quorum: make it clear that quorum logs are for next quorum#79
d4l3k merged 1 commit intomainfrom
d4l3k/quorum_logs

Conversation

@d4l3k
Copy link
Member

@d4l3k d4l3k commented Jan 23, 2025

There's been some confusion and questions about the message the lighthouse prints when no workers have joined the new quorum. This changes the language to make it explicit that the logs are about the new quorum as well as logging the total number of heartbeating replicas.

Test plan:

tristanr@devvm5553 ~/torchft (d4l3k/quorum_logs)> torchft_lighthouse --min_replicas 2 --join_timeout_ms 10000                                                                        (torchft-3.10) 
torchft::lighthouse: 2025-01-23T11:20:09.340-08:00 - INFO Lighthouse listening on: http://devvm5553.cco0.facebook.com:29510
torchft::lighthouse: 2025-01-23T11:20:09.340-08:00 - INFO Next quorum status: New quorum not ready, only have 0 participants, need min_replicas 2 [0/0 participants healthy][0 heartbeating][shrink_only=false]

@d4l3k d4l3k requested review from fegin and mreso January 23, 2025 19:21
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 23, 2025
@d4l3k d4l3k merged commit beb94f0 into main Jan 23, 2025
6 checks passed
@d4l3k d4l3k deleted the d4l3k/quorum_logs branch January 23, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants