Skip to content

skip compiling opt step instead of erroring if opt_in_bwd=True #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

skip compiling opt step instead of erroring if opt_in_bwd=True #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
901723f
rfc
Jun 4, 2025
ab02d75
Revert "rfc"
Jun 4, 2025
1c0117b
Merge branch 'main' of https://github.com/pytorch/torchtune
Jun 6, 2025
1cc6946
Merge branch 'main' of https://github.com/pytorch/torchtune
Jun 11, 2025
08f5dc9
Merge branch 'main' of https://github.com/pytorch/torchtune
Jun 13, 2025
72d0b6f
skip compiling instead of raising error
Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions recipes/full_finetune_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,13 +387,15 @@ def setup(self, cfg: DictConfig) -> None:
)
if self._compile_optimizer_step:
if self._optimizer_in_bwd:
raise ValueError(
"optimizer_in_bwd not supported with compiling the optimizer step"
self._logger.warning(
"Compile optimizer is not supported for optimizer_in_bwd. Setting self._compile_optimizer_step to False."
)
self._compile_optimizer_step = False
else:
self._optimizer.step = torch.compile(
self._optimizer.step,
backend=self._compile_backend,
)
self._optimizer.step = torch.compile(
self._optimizer.step,
backend=self._compile_backend,
)

if self._resume_from_checkpoint:
# If async checkpointing is enabled, intermediate checkpoints are saved asynchronously
Expand Down
14 changes: 8 additions & 6 deletions recipes/qat_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,13 +387,15 @@ def setup(self, cfg: DictConfig) -> None:
)
if self._compile_optimizer_step:
if self._optimizer_in_bwd:
raise ValueError(
"optimizer_in_bwd not supported with compiling the optimizer step"
self._logger.warning(
"Compile optimizer is not supported for optimizer_in_bwd. Setting self._compile_optimizer_step to False."
)
self._compile_optimizer_step = False
else:
self._optimizer.step = torch.compile(
self._optimizer.step,
backend=self._compile_backend,
)
self._optimizer.step = torch.compile(
self._optimizer.step,
backend=self._compile_backend,
)

if self._resume_from_checkpoint:
# If async checkpointing is enabled, intermediate checkpoints are saved asynchronously
Expand Down
Loading