Drop python-3.8 unittest in favor of adding 3.12. Update to python-3.10 for other workflows #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
e15963f to
8d1b090
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: Pull Request resolved: #1020 PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
8d1b090 to
4e2f9d5
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
facebook-github-bot
force-pushed
the
export-D71475986
branch
from
4e2f9d5 to
bc79491
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: Pull Request resolved: #1020 PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
bc79491 to
0312e1d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: Pull Request resolved: #1020 PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
0312e1d to
bb243fb
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
facebook-github-bot
force-pushed
the
export-D71475986
branch
from
bb243fb to
f36cd89
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
f36cd89 to
997fb0a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: Pull Request resolved: #1020 PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
997fb0a to
d2ca93a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
facebook-github-bot
force-pushed
the
export-D71475986
branch
from
d2ca93a to
4d73c73
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
facebook-github-bot
force-pushed
the
export-D71475986
branch
from
4d73c73 to
efc7bbd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 21, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
efc7bbd to
df4e772
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
force-pushed
the
export-D71475986
branch
from
df4e772 to
94d53f3
Compare
kiukchung
added a commit
that referenced
this pull request
Mar 21, 2025
…10 for other workflows (#1020) Summary: Pull Request resolved: #1020 PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
facebook-github-bot
force-pushed
the
export-D71475986
branch
from
94d53f3 to
d8736db
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 21, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
d8736db to
632e4c9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
kiukchung
added a commit
that referenced
this pull request
Mar 21, 2025
…10 for other workflows (#1020) Summary: Pull Request resolved: #1020 PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
kiukchung
force-pushed
the
export-D71475986
branch
from
632e4c9 to
714d74f
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
facebook-github-bot
force-pushed
the
export-D71475986
branch
from
714d74f to
0d782fb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
d4l3k
approved these changes
Mar 21, 2025
Member
d4l3k
left a comment
d4l3k
left a comment
There was a problem hiding this comment.
LGTM
There some other changes as well -- is that intended?
Contributor
Author
yea, the other changes (ones in *.py files) are needed to run tests in python-3.12. |
…10 for other workflows (#1020) Summary: PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: d4l3k, manav-a Differential Revision: D71475986
facebook-github-bot
force-pushed
the
export-D71475986
branch
from
0d782fb to
64e989c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71475986 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main
Changes:
Reviewed By: manav-a
Differential Revision: D71475986