schedulers parameterized #1022
schedulers parameterized #1022
Conversation
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71023681 |
bobyangyf
force-pushed
the
export-D71023681
branch
from
76ef188 to
fce9143
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71023681 |
kiukchung
left a comment
kiukchung
left a comment
There was a problem hiding this comment.
I don't fully understand this change. It seems like you want torchx.schedulers.api.Scheduler interface to be able to deal with both AppDef and PipelineDef in the same API. For instance:
def schedule(desc: Union[AppDef, PipelineDef], ...)
If this is the case, I would discourage you from overloading the scheduler APIs in such a way.
I'd have to fully understand what the intent here is before recommending a good path forward. Happy to meet and discuss.
lgarg26
left a comment
lgarg26
left a comment
There was a problem hiding this comment.
Accepting to unblock ongoing intergration.
Summary: Parameterize Scheduler This not only more precisely expresses it's type (previously was unspecified generic variant of AppDryRunInfo[T] where T was unspecified; not it can be fully specified); This also allows us to inject PipelineDryRunInfo for schedulers that are pipeline schedulers Reviewed By: lgarg26 Differential Revision: D71023681
bobyangyf
force-pushed
the
export-D71023681
branch
from
fce9143 to
83bfe40
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71023681 |
facebook-github-bot
merged commit 9814e75
into
meta-pytorch:main
4 participants
Summary:
Parameterize Scheduler
This not only more precisely expresses it's type (previously was unspecified generic variant of AppDryRunInfo[T] where T was unspecified; not it can be fully specified); This also allows us to inject PipelineDryRunInfo for schedulers that are pipeline schedulers
Differential Revision: D71023681