Skip to content

fix __file__ value inside components #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix __file__ value inside components #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion torchx/specs/finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
# pyre-strict

import abc
import copy
import importlib
import inspect
import logging
Expand Down Expand Up @@ -281,7 +282,9 @@ def find(
)

file_source = read_conf_file(self._filepath)
namespace = globals()
namespace = copy.copy(globals())
# so that __file__ used inside the component points to the correct file
namespace["__file__"] = os.path.abspath(self._filepath)
Copy link
Contributor

@kiukchung kiukchung Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to add a unittest assertion for this (either as a testcase or simply adding an assertion in an existing testcase here: https://github.com/pytorch/torchx/blob/main/torchx/specs/test/finder_test.py#L194)

exec(file_source, namespace) # noqa: P204
if self._function_name not in namespace:
raise ComponentNotFoundException(
Expand Down
Loading