Skip to content

(6/n - non-xlformers conda-on-mast mvp)(torchx/runner) Create //torchx/runner:lib_core with no plugin bundling #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

(6/n - non-xlformers conda-on-mast mvp)(torchx/runner) Create //torchx/runner:lib_core with no plugin bundling #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions torchx/runner/test/config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,20 +470,17 @@ def test_dump_and_load_all_registered_schedulers(self) -> None:
sfile = StringIO()
dump(sfile)

scheduler_factories = {
**get_scheduler_factories(),
**(
get_scheduler_factories(
group="torchx.schedulers.orchestrator", skip_defaults=True
)
or {}
),
}
scheduler_factories = get_scheduler_factories()

for sched_name, sched in scheduler_factories.items():
sfile.seek(0) # reset the file pos
cfg = {}
load(scheduler=sched_name, f=sfile, cfg=cfg)
try:
load(scheduler=sched_name, f=sfile, cfg=cfg)
except ModuleNotFoundError:
# just test the ones that have been installed
continue

for opt_name, _ in sched("test").run_opts():
self.assertTrue(
opt_name in cfg,
Expand Down
Loading