(torchx/components) Remove dependency to pyre_extensions #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
highker
approved these changes
Jul 1, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
402feb2 to
25c0898
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
force-pushed
the
export-D77621041
branch
from
25c0898 to
52dfa9f
Compare
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
force-pushed
the
export-D77621041
branch
from
52dfa9f to
2b107c7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: Pull Request resolved: #1088 There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
force-pushed
the
export-D77621041
branch
from
2b107c7 to
3cd2d68
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: Pull Request resolved: #1088 There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
force-pushed
the
export-D77621041
branch
from
3cd2d68 to
93a787e
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
93a787e to
3d4424b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
3d4424b to
bd3b8ab
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
bd3b8ab to
42efa1b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
42efa1b to
0454db3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
0454db3 to
f39d86c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
f39d86c to
01ace7e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
01ace7e to
e273bc3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
e273bc3 to
d4fd5d8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
force-pushed
the
export-D77621041
branch
from
d4fd5d8 to
9814ea5
Compare
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
force-pushed
the
export-D77621041
branch
from
9814ea5 to
b4d9431
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: Pull Request resolved: #1088 There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
force-pushed
the
export-D77621041
branch
from
b4d9431 to
d7d5d7d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
kiukchung
added a commit
that referenced
this pull request
Jul 2, 2025
Summary: Pull Request resolved: #1088 There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
force-pushed
the
export-D77621041
branch
from
d7d5d7d to
ec8d802
Compare
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
facebook-github-bot
force-pushed
the
export-D77621041
branch
from
ec8d802 to
dbb9c78
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77621041 |
kiukchung
added a commit
that referenced
this pull request
Jul 3, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
kiukchung
added a commit
that referenced
this pull request
Jul 3, 2025
Summary: There was only a single usage of `pyre_extensions` in the entire code base. Get rid of this dependency by using an `assert` statement rather than `pyre_extensions.none_throws`. Reviewed By: highker Differential Revision: D77621041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There was only a single usage of
pyre_extensionsin the entire code base. Get rid of this dependency by using anassertstatement rather thanpyre_extensions.none_throws.Reviewed By: highker
Differential Revision: D77621041