(torchx/runner) Add runner API to parse scheduler config from string literal #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79937463 |
ethanbwaite
force-pushed
the
export-D79937463
branch
from
ecc2b85 to
9d9f82c
Compare
ethanbwaite
added a commit
that referenced
this pull request
Aug 12, 2025
…literal (#1096) Summary: Adds `cfg_from_str` to the runner API to parse scheduler config options from string literals so this logic doesn't need to be duplicated across usecases. Also updates CLI exit message with the full `InvalidRunConfigException` reason string, and fixes a dead link. Differential Revision: D79937463
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79937463 |
ethanbwaite
added a commit
that referenced
this pull request
Aug 12, 2025
…literal (#1096) Summary: Pull Request resolved: #1096 Adds `cfg_from_str` to the runner API to parse scheduler config options from string literals so this logic doesn't need to be duplicated across usecases. Also updates CLI exit message with the full `InvalidRunConfigException` reason string, and fixes a dead link. Differential Revision: D79937463
ethanbwaite
force-pushed
the
export-D79937463
branch
from
9d9f82c to
8d860d8
Compare
ethanbwaite
added a commit
that referenced
this pull request
Aug 13, 2025
…literal (#1096) Summary: Adds `cfg_from_str` to the runner API to parse scheduler config options from string literals so this logic doesn't need to be duplicated across usecases. Also updates CLI exit message with the full `InvalidRunConfigException` reason string, and fixes a dead link. Differential Revision: D79937463
ethanbwaite
force-pushed
the
export-D79937463
branch
from
8d860d8 to
c4d4e08
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79937463 |
ethanbwaite
added a commit
that referenced
this pull request
Aug 13, 2025
…literal (#1096) Summary: Pull Request resolved: #1096 Adds `cfg_from_str` to the runner API to parse scheduler config options from string literals so this logic doesn't need to be duplicated across usecases. Also updates CLI exit message with the full `InvalidRunConfigException` reason string, and fixes a dead link. Differential Revision: D79937463
ethanbwaite
force-pushed
the
export-D79937463
branch
from
c4d4e08 to
23aee8b
Compare
…literal (#1096) Summary: Adds `cfg_from_str` to the runner API to parse scheduler config options from string literals so this logic doesn't need to be duplicated across usecases. Also updates CLI exit message with the full `InvalidRunConfigException` reason string, and fixes a dead link. Differential Revision: D79937463
facebook-github-bot
force-pushed
the
export-D79937463
branch
from
23aee8b to
7248cac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79937463 |
kiukchung
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
cfg_from_strto the runner API to parse scheduler config options from string literals so this logic doesn't need to be duplicated across usecases.Also updates CLI exit message with the full
InvalidRunConfigExceptionreason string, and fixes a dead link.Differential Revision: D79937463