Fix issue handling function with decorator #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82132556 |
kiukchung
approved these changes
Sep 10, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82132556 |
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 10, 2025
Summary: Pull Request resolved: meta-pytorch#1111 Add support to handle function with decorators that hit validation errors. **Root cause:** If the function contains decorators, the getabsfile will return the decorator function filepath. **Fix**: Add an unwrap before we getabsfile, this could lead to right filepath. Reviewed By: kiukchung Differential Revision: D82132556
nghuiqin
force-pushed
the
export-D82132556
branch
from
5609350 to
bd2bbca
Compare
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 10, 2025
Summary: Add support to handle function with decorators that hit validation errors. **Root cause:** If the function contains decorators, the getabsfile will return the decorator function filepath. **Fix**: Add an unwrap before we getabsfile, this could lead to right filepath. Reviewed By: kiukchung Differential Revision: D82132556
nghuiqin
force-pushed
the
export-D82132556
branch
from
bd2bbca to
7dd0de3
Compare
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 10, 2025
Summary: Add support to handle function with decorators that hit validation errors. **Root cause:** If the function contains decorators, the getabsfile will return the decorator function filepath. **Fix**: Add an unwrap before we getabsfile, this could lead to right filepath. Reviewed By: kiukchung Differential Revision: D82132556
nghuiqin
force-pushed
the
export-D82132556
branch
from
7dd0de3 to
96e2f8a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82132556 |
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 10, 2025
Summary: Pull Request resolved: meta-pytorch#1111 Add support to handle function with decorators that hit validation errors. **Root cause:** If the function contains decorators, the getabsfile will return the decorator function filepath. **Fix**: Add an unwrap before we getabsfile, this could lead to right filepath. Reviewed By: kiukchung Differential Revision: D82132556
nghuiqin
force-pushed
the
export-D82132556
branch
from
96e2f8a to
7486e46
Compare
Summary: Pull Request resolved: meta-pytorch#1111 Add support to handle function with decorators that hit validation errors. **Root cause:** If the function contains decorators, the getabsfile will return the decorator function filepath. **Fix**: Add an unwrap before we getabsfile, this could lead to right filepath. Reviewed By: kiukchung Differential Revision: D82132556
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82132556 |
nghuiqin
force-pushed
the
export-D82132556
branch
from
7486e46 to
036bc6d
Compare
facebook-github-bot
merged commit 7f4eeba
into
meta-pytorch:main
23 of 24 checks passed
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Differential Revision: D82346696
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Reviewed By: ethanbwaite Differential Revision: D82346696
nghuiqin
added a commit
to nghuiqin/torchx
that referenced
this pull request
Sep 15, 2025
…ass (meta-pytorch#1116) Summary: We added file decorator support in meta-pytorch#1111 **Problem:** This will fail when the function wrapper with dataclass object **Fix:** Determine if decorators found in function before unwrap. Add two test cases to cover: * comp_f using dataclass in g.py => should return __init__.py * comp_g using decorator in h.py => should return g.py Reviewed By: ethanbwaite Differential Revision: D82346696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add support to handle function with decorators that hit validation errors.
Root cause: If the function contains decorators, the getabsfile will return the decorator function filepath.
Fix: Add an unwrap before we getabsfile, this could lead to right filepath.
Differential Revision: D82132556