(torchx/runner)(1/n) remove useless nested event logging - runner.dryrun #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82238445 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…run (#1112) Summary: remove useless event logging for sub-steps of runner.dryrun(). If these need to be logged they should be logged at the APIs that the runner.dryrun() calls. Differential Revision: D82238445
…run (#1112) Summary: remove useless event logging for sub-steps of runner.dryrun(). If these need to be logged they should be logged at the APIs that the runner.dryrun() calls. Differential Revision: D82238445
facebook-github-bot
force-pushed
the
export-D82238445
branch
from
62b7fba to
4bab44a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82238445 |
ethanbwaite
approved these changes
Sep 11, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
…run (#1112) Summary: remove useless event logging for sub-steps of runner.dryrun(). If these need to be logged they should be logged at the APIs that the runner.dryrun() calls. Differential Revision: D82238445
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
…run (#1112) Summary: remove useless event logging for sub-steps of runner.dryrun(). If these need to be logged they should be logged at the APIs that the runner.dryrun() calls. Differential Revision: D82238445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: remove useless event logging for sub-steps of runner.dryrun(). If these need to be logged they should be logged at the APIs that the runner.dryrun() calls.
Differential Revision: D82238445