Skip to content

(torchx/runner)(1/n) remove useless nested event logging - runner.dryrun #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

(torchx/runner)(1/n) remove useless nested event logging - runner.dryrun #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions torchx/runner/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,12 +419,7 @@ def dryrun(
sched = self._scheduler(scheduler)
resolved_cfg = sched.run_opts().resolve(cfg)

# early validation before build workspace
with log_event(
"pre_build_validate",
scheduler,
):
sched._pre_build_validate(app, scheduler, resolved_cfg)
sched._pre_build_validate(app, scheduler, resolved_cfg)

if workspace and isinstance(sched, WorkspaceMixin):
role = app.roles[0]
Expand All @@ -434,13 +429,7 @@ def dryrun(
logger.info(
'To disable workspaces pass: --workspace="" from CLI or workspace=None programmatically.'
)
with log_event(
"build_workspace_and_update_role",
scheduler,
) as ctx:
sched.build_workspace_and_update_role(role, workspace, resolved_cfg)
ctx._torchx_event.app_image = role.image
ctx._torchx_event.workspace = workspace
sched.build_workspace_and_update_role(role, workspace, resolved_cfg)

if old_img != role.image:
logger.info(
Expand All @@ -453,11 +442,7 @@ def dryrun(
" Either a patch was built or no changes to workspace was detected."
)

with log_event(
"validate",
scheduler,
):
sched._validate(app, scheduler, resolved_cfg)
sched._validate(app, scheduler, resolved_cfg)
dryrun_info = sched.submit_dryrun(app, resolved_cfg)
dryrun_info._scheduler = scheduler
return dryrun_info
Expand Down
Loading