Skip to content

import Workspace from torchx.specs not torchx.workspace #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

import Workspace from torchx.specs not torchx.workspace #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions torchx/cli/cmd_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from torchx.runner import config, get_runner, Runner
from torchx.runner.config import load_sections
from torchx.schedulers import get_default_scheduler_name, get_scheduler_factories
from torchx.specs import CfgVal
from torchx.specs import CfgVal, Workspace
from torchx.specs.finder import (
_Component,
ComponentNotFoundException,
Expand All @@ -36,7 +36,6 @@
)
from torchx.util.log_tee_helpers import tee_logs
from torchx.util.types import none_throws
from torchx.workspace import Workspace


MISSING_COMPONENT_ERROR_MSG = (
Expand Down
4 changes: 2 additions & 2 deletions torchx/runner/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/usr/bin/env python3
# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
#
Expand Down Expand Up @@ -43,6 +42,7 @@
parse_app_handle,
runopts,
UnknownAppException,
Workspace,
)
from torchx.specs.finder import get_component
from torchx.tracker.api import (
Expand All @@ -54,7 +54,7 @@
from torchx.util.session import get_session_id_or_create_new, TORCHX_INTERNAL_SESSION_ID

from torchx.util.types import none_throws
from torchx.workspace.api import Workspace, WorkspaceMixin
from torchx.workspace import WorkspaceMixin

if TYPE_CHECKING:
from typing_extensions import Self
Expand Down
3 changes: 1 addition & 2 deletions torchx/runner/test/config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@
)
from torchx.schedulers import get_scheduler_factories, Scheduler
from torchx.schedulers.api import DescribeAppResponse, ListAppResponse, Stream
from torchx.specs import AppDef, AppDryRunInfo, CfgVal, runopts
from torchx.specs import AppDef, AppDryRunInfo, CfgVal, runopts, Workspace
from torchx.test.fixtures import TestWithTmpDir
from torchx.workspace import Workspace


class TestScheduler(Scheduler):
Expand Down
4 changes: 2 additions & 2 deletions torchx/schedulers/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/usr/bin/env python3
# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
#
Expand All @@ -22,8 +21,9 @@
Role,
RoleStatus,
runopts,
Workspace,
)
from torchx.workspace.api import Workspace, WorkspaceMixin
from torchx.workspace import WorkspaceMixin


DAYS_IN_2_WEEKS = 14
Expand Down
2 changes: 1 addition & 1 deletion torchx/workspace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
* ``memory://foo-bar/`` an in-memory workspace for notebook/programmatic usage
"""

from torchx.workspace.api import walk_workspace, Workspace, WorkspaceMixin # noqa: F401
from torchx.workspace.api import walk_workspace, WorkspaceMixin # noqa: F401
Loading