Skip to content

Conversation

@colin2328
Copy link

Summary:
RFC diff to use monarch's torchrun runner .

creates an app def that

Differential Revision: D86155019

Summary:
RFC diff to use monarch's torchrun runner .

creates an app def that

Differential Revision: D86155019
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 4, 2025

@colin2328 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86155019.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.34%. Comparing base (dd683f4) to head (ce80778).

Files with missing lines Patch % Lines
torchx/components/dist.py 4.54% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
- Coverage   91.63%   91.34%   -0.29%     
==========================================
  Files          84       84              
  Lines        6595     6617      +22     
==========================================
+ Hits         6043     6044       +1     
- Misses        552      573      +21     
Flag Coverage Δ
unittests 91.34% <4.54%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants