Named resourced stubs #1161
Open
Named resourced stubs #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 84 84
Lines 6595 6595
=======================================
Hits 6043 6043
Misses 552 552
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Nov 5, 2025
Summary: Internal Generate stubs for all the methods generated by the decorator of `named_resources`. Previous attempt reverted D83985902 because of autodeps issues. Genrule that looks at the all the named_resources and generates a file `named_resources.pyi` which is used by the test. Three targets added 1. `//torchx/fb:named_resources_gen` 2. `//torchx/specs:named_resources_stubs` 3. `//torchx/specs:named_resources_stubs_lib` Use `//torchx/specs:named_resources_stubs_lib` in the test target. Modify some named resources as well. Differential Revision: D86111386
AbishekS
force-pushed
the
export-D86111386
branch
from
4076b17 to
f8e89a4
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Nov 6, 2025
Summary: Internal Generate stubs for all the methods generated by the decorator of `named_resources`. Previous attempt reverted D83985902 because of autodeps issues. Genrule that looks at the all the named_resources and generates a file `named_resources.pyi` which is used by the test. Three targets added 1. `//torchx/fb/stubgen:generate_named_resources_stub` 2. `//torchx/specs:named_resources_stubs` Introduce a .bzl file and wrapper for our usecase so we can share srcs and deps among two python libraries 1. //torchx/specs:lib_core_srcs - which is used by the other target `//torchx/fb/stubgen:generate_named_resources_stub` to create the stubs 2. //torchx/specs:lib_core - which is as before but with the additional type_stubs included. Additionally, Modify some named resources as well. Fix some imports for completion Differential Revision: D86111386
AbishekS
force-pushed
the
export-D86111386
branch
from
f8e89a4 to
6de0dea
Compare
Summary: Internal Generate stubs for all the methods generated by the decorator of `named_resources`. Previous attempt reverted D83985902 because of autodeps issues. Genrule that looks at the all the named_resources and generates a file `named_resources.pyi` which is used by the test. Three targets added 1. `//torchx/fb/stubgen:generate_named_resources_stub` 2. `//torchx/specs:named_resources_stubs` Introduce a .bzl file and wrapper for our usecase so we can share srcs and deps among two python libraries 1. //torchx/specs:lib_core_srcs - which is used by the other target `//torchx/fb/stubgen:generate_named_resources_stub` to create the stubs 2. //torchx/specs:lib_core - which is as before but with the additional type_stubs included. Additionally, Modify some named resources as well. Fix some imports for completion Differential Revision: D86111386
AbishekS
force-pushed
the
export-D86111386
branch
from
6de0dea to
05965a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D86111386