Use fastmath in GeLU #506
Open
Use fastmath in GeLU #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robieta
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
robieta
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
robieta
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
approved these changes
Oct 2, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Summary: Use fastmath intrinsics in `tanh_approx_fp32` when we don't have a native fast tanh instruction. We need to use the sigmoid formulation rather than dividing two exponents due to numeric stability. Differential Revision: D83082730
facebook-github-bot
force-pushed
the
export-D83082730
branch
from
c330fde to
1a25956
Compare
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Summary: Use fastmath intrinsics in `tanh_approx_fp32` when we don't have a native fast tanh instruction. We need to use the sigmoid formulation rather than dividing two exponents due to numeric stability. Differential Revision: D83082730
facebook-github-bot
force-pushed
the
export-D83082730
branch
from
1a25956 to
e4f881e
Compare
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Summary: Use fastmath intrinsics in `tanh_approx_fp32` when we don't have a native fast tanh instruction. We need to use the sigmoid formulation rather than dividing two exponents due to numeric stability. Differential Revision: D83082730
facebook-github-bot
force-pushed
the
export-D83082730
branch
from
e4f881e to
3aeb7fb
Compare
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use fastmath intrinsics in
tanh_approx_fp32when we don't have a native fast tanh instruction. We need to use the sigmoid formulation rather than dividing two exponents due to numeric stability.Differential Revision: D83082730