Entropy warmup enhencements #651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhou-jpg
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jhou-jpg
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jhou-jpg
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
xuzhao9
approved these changes
Nov 21, 2025
Summary: This diff fixes an implementation error that was impacting slope and r^2 computations. It also includes optimization to the entropy warmup logic that should improve its performance with smaller/faster kernels. Further numerical stability optimization were brought in from the cross-pr on nvbench NVIDIA/nvbench#286 Since entropy tracks the frequency of appearence for each unique time element, the rounding precision applied on individual latency element can impact the characteristics of entropy convergence. This diff introduces logic to dynamically increase rounding precision to maintain a balance between entropy sensitivity and trend detection Reviewed By: xuzhao9 Differential Revision: D87379814
facebook-github-bot
force-pushed
the
export-D87379814
branch
from
bed96e4 to
26aabcb
Compare
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff optimizes the entropy warmup logic and should improve its performance with smaller/faster kernels
Since entropy tracks the frequency of appearence for each unique time element, the rounding precision applied on individual latency element can impact the characteristics of entropy convergence. This diff introduces logic to dynamically increase rounding precision to maintain a balance between entropy sensitivity and trend detection
Differential Revision: D87379814