Refactor log data processing in dataLoader.ts for improved memory efficiency and error handling #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iciency and error handling Summary: - Removed console logs during NDJSON parsing to clean up output. - Introduced a new function, `parseLogDataFromStream`, to handle line-by-line parsing of NDJSON from a stream, enhancing memory efficiency for large files. - Updated `processArrayBuffer` to utilize the new streaming function for gzip files and improved error handling. - Adjusted `loadLogDataFromFile` to use streaming for files exceeding 100 MB, ensuring better performance with large datasets. These changes enhance the robustness and efficiency of log data processing in the application.
meta-cla
bot
added
the
CLA Signed
Comment on lines
+328
to
+335
| try { | ||
| const parsedLine: LogEntry = JSON.parse(line); | ||
| if (parsedLine && typeof parsedLine === 'object') { | ||
| entries.push(parsedLine); | ||
| } | ||
| } catch (e) { | ||
| console.warn(`Failed to parse line as JSON: ${line.substring(0, 100)}...`); | ||
| } |
There was a problem hiding this comment.
very minor nit - you can de-duplicate this with the other place (above) where you handle this logic
| @@ -367,6 +400,18 @@ export async function loadLogData(url: string): Promise<LogEntry[]> { | |||
| * @returns Promise resolving to an array of LogEntry objects | |||
| */ | |||
| export function loadLogDataFromFile(file: File): Promise<LogEntry[]> { | |||
| // For large files, we should use streaming to avoid memory issues | |||
| const LARGE_FILE_THRESHOLD = 100 * 1024 * 1024; // 100 MB | |||
There was a problem hiding this comment.
Can you share the constant with CodeViewer.tsx?
Edit: nvm, I realize it's a different limit
davidberard98
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
parseLogDataFromStream, to handle line-by-line parsing of NDJSON from a stream, enhancing memory efficiency for large files.processArrayBufferto utilize the new streaming function for gzip files and improved error handling.loadLogDataFromFileto use streaming for files exceeding 100 MB, ensuring better performance with large datasets.These changes enhance the robustness and efficiency of log data processing in the application.